Skip to content

Conversation

@Revathyvenugopal162
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (19ae597) to head (2088b25).
Report is 350 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   87.46%   87.39%   -0.07%     
==========================================
  Files          81       81              
  Lines        9204     9197       -7     
==========================================
- Hits         8050     8038      -12     
- Misses       1154     1159       +5     

@PProfizi
Copy link
Contributor

PProfizi commented Aug 16, 2023

@Revathyvenugopal162 Please check the doc before merging.
There has been an issue since #954 with newer pyvista rendering scalar bars wrong
Which is why it has been pinned to an older version in requirements_docs.txt for a long time.
No clue as to the origin of the issue.
It is also still the case with PyVista 0.41.1 #1116

@Revathyvenugopal162
Copy link
Contributor Author

@Revathyvenugopal162 Please check the doc before merging. There has been an issue since #954 with newer pyvista rendering scalar bars wrong Which is why it has been pinned to an older version in requirements_docs.txt for a long time. No clue as to the origin of the issue. It is also still the case with PyVista 0.41.1 #1116

Thanks for notifying this @PProfizi , then we can keep pyvista as it is, Since no other docs dependency is direct dependent of pyvista, we can upgrade other requirements especially sphinx and ansys-sphinx theme ( the logo that we have right now in pydpf is older logo)

@PProfizi
Copy link
Contributor

HI @Revathyvenugopal162 is this still an active topic? I think we can close as stale or not needed anymore.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can close this issue, @PProfizi.

@PProfizi PProfizi closed this Oct 28, 2024
@PProfizi PProfizi deleted the maint/update-requirements branch October 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants